Bar graph selection #2409
Merged
Bar graph selection #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
188129121-bar-graph-sync
to
188127118-bar-graph-link
September 17, 2024 17:05
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2409 +/- ##
==========================================
- Coverage 86.31% 86.28% -0.03%
==========================================
Files 739 739
Lines 37955 38018 +63
Branches 9680 9701 +21
==========================================
+ Hits 32759 32802 +43
- Misses 4900 4917 +17
- Partials 296 299 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
collaborative-learning
|
||||||||||||||||||||||||||||
| Project |
collaborative-learning
|
| Branch Review |
188129114-bar-graph-select
|
| Run status |
|
| Run duration | 13m 53s |
| Commit |
|
| Committer | Boris Goldowsky |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
3
|
Skipped
|
0
|
Passing
|
111
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT-188129114
Implements selection features:
Note that modifier keys are not implemented as part of this PR, nor is any behavior for clicking or dragging on the background of the bar graph tile, so you cannot deselect cases that you selected by clicking on a bar.