Make history playback work for "X It!" #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2410 +/- ##
==========================================
- Coverage 86.29% 86.28% -0.02%
==========================================
Files 739 739
Lines 38018 38047 +29
Branches 9701 9717 +16
==========================================
+ Hits 32807 32827 +20
- Misses 4912 4921 +9
Partials 299 299
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
collaborative-learning
|
||||||||||||||||||||||||||||
| Project |
collaborative-learning
|
| Branch Review |
188129121-history-bug-fixes
|
| Run status |
|
| Run duration | 13m 49s |
| Commit |
|
| Committer | Boris Goldowsky |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
3
|
Skipped
|
0
|
Passing
|
111
|
| View all changes introduced in this branch ↗︎ | |
Take more care with undefined vs. falsy
scytacki
approved these changes
Sep 20, 2024
scytacki
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in PT-188129121 , a bar graph created with the "Bar Graph It!" button from a table did not have its history recorded in a way that could play back without errors. In fact this was failing for other tiles (data cards, graph) created with shared models pre-attached; changes made in response to the shared model were recorded in history before the creation of the tile, and thus would fail on replay.
This PR is more careful about the order in which these events are recorded in history. In addition, some deeper issues with the Data Card tile are addressed so that undo, redo, and history playback should now work for the "Data Card It!" case.