-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh class roster plus refactor #2418
Open
scytacki
wants to merge
10
commits into
master
Choose a base branch
from
188181646-update-class-roster
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Sep 30, 2024
-
This uses applySnapshot to update the class users in place. This will make code using these users more efficient since they can just observer the user properties for changes.
Configuration menu - View commit details
-
Copy full SHA for b83aeb1 - Browse repository at this point
Copy the full SHA b83aeb1View commit details -
Switch to using the MST environment for the groups store
Original the MST environment was avoided because I was planning to switch this store to just be MobX. However the group store needs to be synced with the data from the database, and it is easier to do that using MST than MobX.
Configuration menu - View commit details
-
Copy full SHA for 40e6e50 - Browse repository at this point
Copy the full SHA 40e6e50View commit details -
This uses applySnapshot to sync the changes from the DB. This way the existing objects are updated instead of creating new ones. I also missed a change in stores when committing the last set of changes.
Configuration menu - View commit details
-
Copy full SHA for 6e1bb13 - Browse repository at this point
Copy the full SHA 6e1bb13View commit details -
look up users instead of copying full name and initials
This will allow us to update the users later and have the group views automatically update without having to also update the group user objects. This also removes the option to skip unknown students. They are part of the group so we should show them even if we don't know who they are yet.
Configuration menu - View commit details
-
Copy full SHA for 4dc5ccb - Browse repository at this point
Copy the full SHA 4dc5ccbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 58ee2d4 - Browse repository at this point
Copy the full SHA 58ee2d4View commit details -
We use a timestamp for when the class information is retrieved from the portal. And compare this to the timestamp in the groupUser to figure out if this groupUser is older than the class info or newer than the class info.
Configuration menu - View commit details
-
Copy full SHA for b65fc23 - Browse repository at this point
Copy the full SHA b65fc23View commit details -
portal service object and refresh class info
The portal service object provides a place to store portal info like JWTs, and methods that use and update this info. This new object is used to refresh the class info if necessary after updating the group info from Firebase.
Configuration menu - View commit details
-
Copy full SHA for 6650ed8 - Browse repository at this point
Copy the full SHA 6650ed8View commit details
Commits on Oct 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 83c688a - Browse repository at this point
Copy the full SHA 83c688aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 575ba10 - Browse repository at this point
Copy the full SHA 575ba10View commit details
Commits on Oct 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5eea6af - Browse repository at this point
Copy the full SHA 5eea6afView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.