Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh class roster plus refactor #2418

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Commits on Sep 30, 2024

  1. update class users in place

    This uses applySnapshot to update the class users in place.
    This will make code using these users more efficient since they can just observer the user properties for changes.
    scytacki committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b83aeb1 View commit details
    Browse the repository at this point in the history
  2. Switch to using the MST environment for the groups store

    Original the MST environment was avoided because I was planning to
    switch this store to just be MobX. However the group store needs to
    be synced with the data from the database, and it is easier to do that
    using MST than MobX.
    scytacki committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    40e6e50 View commit details
    Browse the repository at this point in the history
  3. Sync the group membership

    This uses applySnapshot to sync the changes from the DB. This way the existing objects are updated instead of creating new ones.
    
    I also missed a change in stores when committing the last set of changes.
    scytacki committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    6e1bb13 View commit details
    Browse the repository at this point in the history
  4. look up users instead of copying full name and initials

    This will allow us to update the users later and have the group views automatically update without having to also update the group user objects.
    
    This also removes the option to skip unknown students. They are part of the group so we should show them even if we don't know who they are yet.
    scytacki committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    4dc5ccb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    58ee2d4 View commit details
    Browse the repository at this point in the history
  6. add support for removed users

    We use a timestamp for when the class information is retrieved from the portal. And compare this to the timestamp in the groupUser to figure out if this groupUser is older than the class info or newer than the class info.
    scytacki committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b65fc23 View commit details
    Browse the repository at this point in the history
  7. portal service object and refresh class info

    The portal service object provides a place to store portal info like JWTs, and methods that use and update this info.
    
    This new object is used to refresh the class info if necessary after updating the group info from Firebase.
    scytacki committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    6650ed8 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Configuration menu
    Copy the full SHA
    83c688a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    575ba10 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. add test of removed users

    scytacki committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    5eea6af View commit details
    Browse the repository at this point in the history