Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use diagram-view 1.0.0 #2424

Merged
merged 3 commits into from
Oct 15, 2024
Merged

use diagram-view 1.0.0 #2424

merged 3 commits into from
Oct 15, 2024

Conversation

scytacki
Copy link
Member

@scytacki scytacki commented Oct 8, 2024

This brings in:

  • a rounding change that was missing before.
  • a fix so the units are not shared between different diagrams in the same browser window
  • a fix for units like "S" that crashed documents

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.27%. Comparing base (df5f4ab) to head (7cf5ede).
Report is 59 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2424      +/-   ##
==========================================
- Coverage   86.29%   86.27%   -0.02%     
==========================================
  Files         742      742              
  Lines       38353    38354       +1     
  Branches     9796     9796              
==========================================
- Hits        33096    33091       -5     
- Misses       4957     4963       +6     
  Partials      300      300              
Flag Coverage Δ
cypress ?
cypress-regression 78.09% <100.00%> (+0.03%) ⬆️
cypress-smoke 27.92% <0.00%> (-0.01%) ⬇️
jest 48.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Oct 8, 2024

collaborative-learning    Run #14014

Run Properties:  status check passed Passed #14014  •  git commit 7cf5ede3fb: update cypress test to match new rounding rule
Project collaborative-learning
Run status status check passed Passed #14014
Run duration 01m 41s
Commit git commit 7cf5ede3fb: update cypress test to match new rounding rule
Committer Scott Cytacki
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1

@scytacki scytacki changed the title use diagram-view 1.0.0-beta.3 use diagram-view 1.0.0 Oct 11, 2024
Copy link
Contributor

@bgoldowsky bgoldowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@scytacki scytacki merged commit ed3949d into master Oct 15, 2024
16 of 17 checks passed
@scytacki scytacki deleted the 188332731-use-new-diagram-view branch October 15, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants