Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create multiple ai comments #2426

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Conversation

bgoldowsky
Copy link
Contributor

Followup work on PT-188092997

  • Allow creation of multiple comments by the AI evaluation. A new comment will be added each time the evaluator runs, as per request in Slack.
  • Remove restriction to the AI demo space.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.28%. Comparing base (7be444b) to head (a15f548).
Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/firebase.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2426      +/-   ##
==========================================
- Coverage   86.31%   86.28%   -0.03%     
==========================================
  Files         745      745              
  Lines       38493    38498       +5     
  Branches     9825     9826       +1     
==========================================
- Hits        33224    33219       -5     
- Misses       4969     4979      +10     
  Partials      300      300              
Flag Coverage Δ
cypress ?
cypress-regression 78.13% <83.33%> (-0.02%) ⬇️
cypress-smoke 28.08% <83.33%> (-0.01%) ⬇️
jest 48.81% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Oct 15, 2024

collaborative-learning    Run #14037

Run Properties:  status check passed Passed #14037  •  git commit a15f548fbd: Remove aiEvaluation from "qa" unit.
Project collaborative-learning
Run status status check passed Passed #14037
Run duration 14m 27s
Commit git commit a15f548fbd: Remove aiEvaluation from "qa" unit.
Committer Boris Goldowsky
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 3
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 115

Copy link
Member

@scytacki scytacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Lets see how it works 🤞

We don't want to blow our AI budget on analyzing documents created by Cypress tests.
@bgoldowsky bgoldowsky merged commit d0f4eb0 into master Oct 17, 2024
14 of 17 checks passed
@bgoldowsky bgoldowsky deleted the 188092997-multiple-ai-comments branch October 17, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants