Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update diagram view to 1.0.1 #2430

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

scytacki
Copy link
Member

@scytacki scytacki commented Nov 6, 2024

Copy link

cypress bot commented Nov 6, 2024

collaborative-learning    Run #14105

Run Properties:  status check passed Passed #14105  •  git commit 34d0892d59: update diagram view to 1.0.1
Project collaborative-learning
Branch Review 188476962-update-diagram-view
Run status status check passed Passed #14105
Run duration 14m 58s
Commit git commit 34d0892d59: update diagram view to 1.0.1
Committer Scott Cytacki
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 3
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 117
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.34%. Comparing base (8c24196) to head (34d0892).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2430      +/-   ##
==========================================
- Coverage   86.35%   86.34%   -0.01%     
==========================================
  Files         746      746              
  Lines       38658    38658              
  Branches     9867     9867              
==========================================
- Hits        33383    33381       -2     
- Misses       4975     4977       +2     
  Partials      300      300              
Flag Coverage Δ
cypress ?
cypress-regression 78.28% <100.00%> (+0.02%) ⬆️
cypress-smoke 28.46% <100.00%> (-0.01%) ⬇️
jest 48.74% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bgoldowsky bgoldowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@scytacki scytacki merged commit 59bf034 into master Nov 6, 2024
19 checks passed
@scytacki scytacki deleted the 188476962-update-diagram-view branch November 6, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants