Fix bug in copying multi-dataset Coordinate Grid tiles. #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can't be index by provider ID since copied datasets don't have any provider tile.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2432 +/- ##
==========================================
- Coverage 86.36% 86.34% -0.02%
==========================================
Files 746 746
Lines 38659 38663 +4
Branches 9868 9871 +3
==========================================
- Hits 33388 33385 -3
- Misses 4972 4979 +7
Partials 299 299
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
collaborative-learning
|
||||||||||||||||||||||||||||
| Project |
collaborative-learning
|
| Branch Review |
188559155-copy-multi-dataset-grids
|
| Run status |
|
| Run duration | 15m 24s |
| Commit |
|
| Committer | Boris Goldowsky |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
3
|
Skipped
|
0
|
Passing
|
117
|
| View all changes introduced in this branch ↗︎ | |
scytacki
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where after copying a Geometry tile, not all linked datasets were being displayed.
Changes the return value of getLinkedPointsData, which was previously a hash indexed by the
providerIdof each linked SharedDataSet. After a tile copy operation, the newly-created SharedDataSet copies have no providerId any more, so this was being indexed byundefined.Change this to using the SharedDataSet id as the hash key, and include the providerId in each point's properties.