feat: AI-categorized docs show in strategy sorts (PT-188476611) #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2433 +/- ##
=======================================
Coverage 86.36% 86.37%
=======================================
Files 746 746
Lines 38659 38659
Branches 9868 9868
=======================================
+ Hits 33388 33390 +2
+ Misses 4972 4970 -2
Partials 299 299
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
collaborative-learning
|
||||||||||||||||||||||||||||
| Project |
collaborative-learning
|
| Branch Review |
188476611-ai-categorized-docs-show-in-strategy-sorts
|
| Run status |
|
| Run duration | 14m 48s |
| Commit |
|
| Committer | Ethan McElroy |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
3
|
Skipped
|
0
|
Passing
|
117
|
| View all changes introduced in this branch ↗︎ | |
We'll remove this in a separate PR later.
scytacki
deleted the
188476611-ai-categorized-docs-show-in-strategy-sorts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#188476611
Adds a Cloud Function that will watch for comments and update the related document's strategies array with tag values in the comment. The function will also delete values from the document's strategies array if a comment containing tags is deleted and no other comments contain the same tags.
Also included is a small change to the
emulatorscript infunctions-v2. It will now save and load data from the newfunctions-v2/emulator-datadirectory so that state will persist between emulator runs.