-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translating nn and nb #91
base: master
Are you sure you want to change the base?
Conversation
several new nn and nb
Should "credits": include name of translator like |
Thank you.
I don't think so. "credits" specifies the content of the credits dialog. You can see it when you click on Concord Consortium logo in the lower-left corner. |
added i18nMetadata and updatet files
Updated i18nmetadata in fresh files (translations) and updated the metadata-files with information about the translated files. |
Thanks. I think the English versions are missing "i18nMetadata" value. It's necessary to be able to see the flag button and be able to switch to another language. |
@ghveem there are still some issues with this pull request. Have you run this locally? If so you will see that most (all?) of the translated interactives don't have the flag to allow the user to switch languages. To fix that you'll need to edit the english version of the interactive so that the "i18nMetadata" property points to the metadata file that describes where to find the other languages. You've added this information to your own translated interactive files, but not to the english version of the file. See https://github.com/concord-consortium/lab-interactives-site/blob/master/src/interactives/samples/1-oil-and-water-shake.json for a working example. Also the text on line 5 of src/locales/nb/interactives/sam/intermolecular-attractions/3-2-boiling-point-and-solubility.json should be on line 4 to close the quotes. Same for line 76 of src/locales/nb/interactives/sam/intermolecular-attractions/4-strengthening-dipole-dipole-attractions.json And line 76 of src/locales/nn/interactives/sam/intermolecular-attractions/4-strengthening-dipole-dipole-attractions.json |
I'm sorry. This is not ready or ment to be a PR. I just tried to sync our version from your master. |
several new nn and nb