Merge pull request #71 from concord-consortium/188345477-fix-dataset-…

…attribute-loading fix: Dataset views not loading saved attribute [PT-188345477]
concord-consortium · Sep 27, 2024 · 1a71fe0 · 1a71fe0
2 parents d730a40 + 58360df
commit 1a71fe0
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/hooks/use-codap.ts b/src/hooks/use-codap.ts
@@ -75,10 +75,12 @@ export const useCODAP = ({onCODAPDataChanged, getGraph, setGraph, setInitialGrap
     }]);
   };
 
-  const handleDataChanged = useCallback(async ({datasetName, collectionName, attributeName}: CODAPAttribute) => {
+  const handleDataChanged = useCallback(async (codapAttribute: CODAPAttribute, viewModeOverride?: ViewMode ) => {
+    const {datasetName, collectionName, attributeName} = codapAttribute;
     const values = await getValuesForAttribute(datasetName, collectionName, attributeName);
     const valuesChanged = !valuesRef.current || (JSON.stringify(values) !== JSON.stringify(valuesRef.current));
-    if (viewMode === "dataset" && valuesChanged) {
+    const currentViewMode = viewModeOverride ?? viewMode;
+    if (currentViewMode === "dataset" && valuesChanged) {
       onCODAPDataChanged(values);
       valuesRef.current = values;
     }
@@ -100,7 +102,7 @@ export const useCODAP = ({onCODAPDataChanged, getGraph, setGraph, setInitialGrap
       } else {
         if (values?.attribute) {
           setAttribute(values.attribute);
-          handleDataChanged(values.attribute);
+          handleDataChanged(values.attribute, values.viewMode);
         }
       }
     }