Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added reset and home button [PT-187321069] [PT-187361590] #39

Merged
merged 1 commit into from
Apr 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/components/app.scss
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,12 @@
}
}

label {
display: block;
white-space: nowrap;
font-weight: bold;
}

.generate {
display: flex;
flex-direction: column;
Expand All @@ -118,12 +124,6 @@
flex-direction: column;
gap: 5px;

label {
display: block;
white-space: nowrap;
font-weight: bold;
}

select {
padding: 2px;
width: 100%;
Expand Down
51 changes: 31 additions & 20 deletions src/components/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export const App = () => {
}
}, [sequenceGroups]);

const graphEmpty = useCallback(() => graph.nodes.length === 0, [graph]);
const graphEmpty = useMemo(() => graph.nodes.length === 0, [graph]);

const generateNewSequence = useCallback(async () => {
currentSequence.current = [];
Expand Down Expand Up @@ -274,7 +274,7 @@ export const App = () => {
}, [generateNewSequence, animateCurrentSequenceIndex, startAnimationInterval]);

const uiForGenerate = () => {
const disabled = graphEmpty();
const disabled = graphEmpty;
const playLabel = generationMode === "playing" ? "Pause" : (generationMode === "paused" ? "Resume" : "Play");
const PlayOrPauseIcon = generationMode === "playing" ? PauseIcon : PlayIcon;
const onPlayClick = generationMode === "playing"
Expand Down Expand Up @@ -346,6 +346,7 @@ export const App = () => {
const disabled = sequenceGroups.length === 0;
return (
<div className="sequence-output">
<label>Output:</label>
<div className="output">
<div className="inner-output" ref={innerOutputRef}>
{sequenceGroups.map((group, i) => {
Expand Down Expand Up @@ -382,6 +383,19 @@ export const App = () => {
notifyStateIsDirty();
};

const handleReset = () => {
if (confirm("Are you sure you want to reset?\n\nAny changes you have made will be lost.")) {
setGraph({nodes: [], edges: []});
}
};

const handleReturnToMainMenu = () => {
if (confirm("Are you sure you want to reset?\n\nAny changes you have made will be lost.")) {
setGraph({nodes: [], edges: []});
setViewMode(undefined);
}
};

if (loadState === "loading") {
return <div className="loading">Loading ...</div>;
}
Expand Down Expand Up @@ -410,23 +424,18 @@ export const App = () => {
);
}

if (graphEmpty() && viewMode === "dataset") {
const maybeRenderRightBar = () => {
if (viewMode === "dataset" && graphEmpty) {
return;
}

return (
<div className={clsx("app", { dragging })}>
<div className="instructions">
<h2>Markov Chains</h2>
<p>
This plugin generates sequences of text using a Markov chain. The plugin uses a Markov chain built from a
dataset in CODAP. The dataset must have a column of states. The plugin will build a Markov chain from the
states, and then allow generation of a sequence of text using the Markov chain.
</p>
<p>
To use the plugin, first drag an attribute into the plugin.
</p>
</div>
<div className="right">
{uiForGenerate()}
{sequenceOutput()}
</div>
);
}
};

return (
<div className={clsx("app", { dragging })}>
Expand All @@ -445,6 +454,8 @@ export const App = () => {
setGraph={setGraph}
setHighlightNode={setHighlightNode}
setSelectedNodeId={setSelectedNodeId}
onReset={handleReset}
onReturnToMainMenu={handleReturnToMainMenu}
/>
:
<Dataset
Expand All @@ -455,14 +466,14 @@ export const App = () => {
highlightAllNextNodes={highlightAllNextNodes}
selectedNodeId={selectedNodeId}
animating={animating}
graphEmpty={graphEmpty}
setSelectedNodeId={setSelectedNodeId}
onReset={handleReset}
onReturnToMainMenu={handleReturnToMainMenu}
/>
}
</div>
<div className="right">
{uiForGenerate()}
{sequenceOutput()}
</div>
{maybeRenderRightBar()}
</div>
</div>
);
Expand Down
39 changes: 35 additions & 4 deletions src/components/dataset.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,53 @@ interface Props {
graph: GraphData;
selectedNodeId?: string;
animating: boolean;
graphEmpty: boolean;
setSelectedNodeId: (id?: string, skipToggle?: boolean) => void;
onReset: () => void;
onReturnToMainMenu: () => void;
}

const tools: Tool[] = ["select","fitView","recenter","reset","home"];

export const Dataset = (props: Props) => {
const {highlightNode, highlightLoopOnNode, highlightEdge, highlightAllNextNodes,
graph, setSelectedNodeId, selectedNodeId, animating} = props;
graph, graphEmpty, setSelectedNodeId, selectedNodeId, animating, onReset, onReturnToMainMenu} = props;


const handleToolSelected = (tool: Tool) => {
// TBD
};

if (graphEmpty) {
return (
<div className="dataset">
<Toolbar
tools={["home"]}
onToolSelected={handleToolSelected}
onReset={onReset}
onReturnToMainMenu={onReturnToMainMenu}
/>
<div className="instructions">
<h2>Markov Chains</h2>
<p>
This plugin generates sequences of text using a Markov chain. The plugin uses a Markov chain built from a
dataset in CODAP. The dataset must have a column of states. The plugin will build a Markov chain from the
states, and then allow generation of a sequence of text using the Markov chain.
</p>
<p>
To use the plugin, first drag an attribute into the plugin.
</p>
</div>
</div>
);
}

return (
<div className="dataset">
<Toolbar tools={tools} onToolSelected={handleToolSelected} />
<Toolbar
tools={["select","fitView","recenter","reset","home"]}
onToolSelected={handleToolSelected}
onReset={onReset}
onReturnToMainMenu={onReturnToMainMenu}
/>
<Graph
mode="dataset"
graph={graph}
Expand Down
13 changes: 10 additions & 3 deletions src/components/drawing.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,14 @@
setGraph: React.Dispatch<React.SetStateAction<GraphData>>;
setHighlightNode: React.Dispatch<React.SetStateAction<Node | undefined>>
setSelectedNodeId: (id?: string, skipToggle?: boolean) => void;
onReset: () => void;
onReturnToMainMenu: () => void;
}

export const Drawing = (props: Props) => {
const {highlightNode, highlightLoopOnNode, highlightEdge, highlightAllNextNodes,
graph, setGraph, setHighlightNode, setSelectedNodeId: _setSelectedNodeId, selectedNodeId, animating} = props;
graph, setGraph, setHighlightNode, setSelectedNodeId: _setSelectedNodeId,
selectedNodeId, animating, onReset, onReturnToMainMenu} = props;
const [drawingMode, setDrawingMode] = useState<DrawingMode>("select");
const [firstEdgeNode, setFirstEdgeNode] = useState<Node|undefined>(undefined);
const [rubberBand, setRubberBand] = useState<RubberBand|undefined>(undefined);
Expand Down Expand Up @@ -96,7 +99,7 @@
*/

const addNode = useCallback(({x, y}: {x: number, y: number}) => {
console.log("ADD NODE");

Check warning on line 102 in src/components/drawing.tsx

View workflow job for this annotation

GitHub Actions / Build

Unexpected console statement

Check warning on line 102 in src/components/drawing.tsx

View workflow job for this annotation

GitHub Actions / S3 Deploy

Unexpected console statement
setGraph(prev => {
const id = nanoid();
const label = `State ${prev.nodes.length + 1}`;
Expand Down Expand Up @@ -124,7 +127,6 @@
}, [setGraph]);

const handleClicked = useCallback((e: React.MouseEvent<HTMLDivElement>) => {
console.log("HANDLE CLICKED");
if (drawingMode === "addNode") {
addNode(translateToGraphPoint(e));
// handleSetSelectMode();
Expand Down Expand Up @@ -244,7 +246,12 @@

return (
<div className="drawing">
<Toolbar tools={tools} onToolSelected={handleToolSelected} />
<Toolbar
tools={tools}
onToolSelected={handleToolSelected}
onReset={onReset}
onReturnToMainMenu={onReturnToMainMenu}
/>
<Graph
mode="drawing"
drawingMode={drawingMode}
Expand Down
10 changes: 8 additions & 2 deletions src/components/toolbar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import "./toolbar.scss";
export const allTools = ["select","addNode","addEdge","addText","delete","fitView","recenter","reset","home"] as const;
const toggleableTools: Tool[] = ["select","addNode","addEdge","addText","delete"];
const nonTopTools: Tool[] = ["reset","home"];
const notImplementedTools: Tool[] = ["addText","fitView","recenter","reset","home"];
const notImplementedTools: Tool[] = ["addText","fitView","recenter"];

export type Tool = typeof allTools[number];

Expand Down Expand Up @@ -53,6 +53,8 @@ interface ToolbarButtonProps {
interface ToolbarProps {
tools: Tool[]
onToolSelected: (tool: Tool) => void;
onReset: () => void;
onReturnToMainMenu: () => void;
}

export const ToolbarButton = ({tool, selectedTool, onClick}: ToolbarButtonProps) => {
Expand All @@ -74,12 +76,16 @@ export const ToolbarButton = ({tool, selectedTool, onClick}: ToolbarButtonProps)
);
};

export const Toolbar = ({tools, onToolSelected}: ToolbarProps) => {
export const Toolbar = ({tools, onToolSelected, onReset, onReturnToMainMenu}: ToolbarProps) => {
const [selectedTool, setSelectedTool] = useState<Tool>("select");

const handleToolSelected = (tool: Tool) => {
if (toggleableTools.includes(tool)) {
setSelectedTool(tool);
} else if (tool === "reset") {
onReset();
} else if (tool === "home") {
onReturnToMainMenu();
}
onToolSelected(tool);
};
Expand Down
Loading