Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Copy/paste error with main menu button confirm dialog [PT-187361590] #41

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

dougmartin
Copy link
Member

@dougmartin dougmartin commented Apr 5, 2024

No description provided.

@dougmartin dougmartin changed the title fix: Copy/paste error with main menu button confirm dialog [PT-187361… fix: Copy/paste error with main menu button confirm dialog [PT-187361590] Apr 5, 2024
@dougmartin dougmartin requested a review from eireland April 5, 2024 06:15
@@ -388,7 +388,7 @@ export const App = () => {
};

const handleReturnToMainMenu = () => {
if (confirm("Are you sure you want to reset?\n\nAny changes you have made will be lost.")) {
if (confirm("Are you sure you want to go back to the main menu?\n\nAny changes you have made will be lost.")) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to add the second line break?

Suggested change
if (confirm("Are you sure you want to go back to the main menu?\n\nAny changes you have made will be lost.")) {
if (confirm("Are you sure you want to go back to the main menu?\nAny changes you have made will be lost.")) {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

Copy link

@eireland eireland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want the second line break? It looks like too much whitespace.
Otherwise, looks good.

Base automatically changed from 187374205-allow-play-during-step to master April 5, 2024 15:24
@dougmartin dougmartin merged commit b161142 into master Apr 5, 2024
2 checks passed
@dougmartin dougmartin deleted the fix-confirm-dialog-text branch April 5, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants