Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only response to CODAP data changes in dataset mode [PT-187361590] #45

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

dougmartin
Copy link
Member

Without this the view could update if the user went from dataset more to drawing mode through the main menu button.

Without this the view could update if the user went from dataset more to drawing mode through the main menu button.
@dougmartin dougmartin requested a review from eireland April 5, 2024 14:49
Copy link

@eireland eireland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Base automatically changed from 187321139-refactor-app-layout to master April 5, 2024 15:26
@dougmartin dougmartin merged commit dd64fb7 into master Apr 5, 2024
2 checks passed
@dougmartin dougmartin deleted the 187361590-fix-stop-listening-to-changes branch April 5, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants