Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reset back to initial model, if any [PT-187321069] #50

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

dougmartin
Copy link
Member

No description provided.

@dougmartin dougmartin requested a review from eireland April 7, 2024 12:12

const handleReturnToMainMenu = () => {
if (confirm("Are you sure you want to go back to the main menu?\n\nAny changes you have made will be lost.")) {
setGraph({nodes: [], edges: []});
setInitialGraph(undefined);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming Jie wants initial graph erased when going back to main menu instead of a saved state?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

Copy link

@eireland eireland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a question on what state we want the graph to be in when we return to main menu. Othewise looks good.

Base automatically changed from 187357469-fix-negative-probability-slider to master April 8, 2024 16:18
@dougmartin dougmartin merged commit 15dfd10 into master Apr 8, 2024
2 checks passed
@dougmartin dougmartin deleted the 187321069-update-reset-to-use-loaded-model branch April 8, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants