[#185004673] Focus plugin when clicked anywhere in the component #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougmartin
approved these changes
Sep 28, 2023
| @@ -44,7 +45,7 @@ export const Hierarchy = (props: IProps) => { | |||
| }; | |||
|
|
|||
| return ( | |||
| <> | |||
| <div className={css.hierarchyWrapper} onClick={handleShowComponent}> | |||
There was a problem hiding this comment.
Do we need these inner onClick handlers here and on the table view since you also added it to the outer app?
There was a problem hiding this comment.
There is no outer app. The select view, heirarchy view, and the nested table view replace each other as the app so I had to add the onClick handler to each of the views.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to bring component forward when clicked anywhere in the component.
The script that does the focusing is in
useCodapStateandconnect.js. Then rest of the files are just passing in the onClick handler