Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

186024366 flex fixed header #28

Merged
merged 21 commits into from
Oct 24, 2023
Merged

186024366 flex fixed header #28

merged 21 commits into from
Oct 24, 2023

Conversation

eireland
Copy link
Contributor

Fixes table headers in Portrait view.
Changes had to be made to the value scrolling because of the sticky headers.

eireland and others added 20 commits October 3, 2023 15:48
Moves the intersectionObserver into the data call part of the code from the row part of the code.

Adds position relative to the parent data cell, so we can position the text div absolute.
Adds counter state to trigger rerender on scroll or intersectObserver cahnges.
Copy link
Member

@dougmartin dougmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

src/components/portrait-view.tsx Show resolved Hide resolved
src/components/draggable-table-tags.tsx Outdated Show resolved Hide resolved
@eireland
Copy link
Contributor Author

Adds the prop that passes the parent level to the data cell for the sticky header calculation so we can remove the hack.
Fixes (though not perfectly) the case where wrapped text is getting pushed into the next cell as we scroll.

Copy link
Collaborator

@lublagg lublagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@eireland
Copy link
Contributor Author

Removed imperfect fix for wrapped text going into next cel

@eireland eireland merged commit 8e80b74 into main Oct 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants