Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown icon issue that was causing dragging bug. (PT-188114776) #37

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

lublagg
Copy link
Collaborator

@lublagg lublagg commented Aug 22, 2024

Because the dropdown icon was positioned absolutely, it was appearing only at the top right corner of the app. When the user went to drag a table header, it caused it to look as though the whole area up to where the dropdown icon was positioned was being dragged along with it.

Here's an screenshot:
Screenshot 2024-08-21 at 4 19 58 PM

The changes made assume that the dropdown icon should actually appear within the table header.

Copy link
Member

@dougmartin dougmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@lublagg lublagg merged commit e044fcb into main Aug 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants