Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor table cells + precisions / attrTypes / visibilities. #44

Merged
merged 7 commits into from
Oct 8, 2024

Conversation

lublagg
Copy link
Collaborator

@lublagg lublagg commented Sep 30, 2024

This PR makes the following changes:

  • Moves all of the Nested Table view components into their own folder, and creates sub-folders for the different types of nested views
  • Replaces the mapValuesToCells function with a TableCells component and removes the TableCell component (to remain consistent with the plural TableHeaders)
  • Replaces the getAttrVisibilities, getAttrPrecisions and getAttrTypes utility functions with views on the Collections model
  • Creates a getDisplayValue helper function that will return a cell value with the correct precision / formatting
  • The EditableCell component displays the returned value from getDisplayValue, instead of just the raw value

Base automatically changed from 186024205-add-attribute-in-nested-table-2 to main October 5, 2024 17:29
Copy link
Contributor

@emcelroy emcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes look good, @lublagg 👍 I merged in changes from main after @scytacki helped simplify the setting of focus when a new attribute is added. I also made a few small fixes for bugs unrelated to your changes. Could you please review and make sure things look OK?

Now that I write that out, I realize it would've been better if I had made a separate branch for the bug fixes. The separate commits should allow you view them in isolation, but if it's too confusing, let me know and I'll move them to a new branch.

@lublagg lublagg merged commit 5d46dcc into main Oct 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants