Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create skeleton of plugin (PT-185950946) #1

Merged
merged 27 commits into from
Sep 25, 2023
Merged

Conversation

lublagg
Copy link
Collaborator

@lublagg lublagg commented Sep 1, 2023

This PR creates a basic template of the NASS Plugin. It is essentially a copy of the Microdata Plugin but translated into a React app. Note that there are some files in the 'scripts' folder which will most likely be changed / re-structured into other files at some point.

@lublagg lublagg changed the title Test deployment. Create skeleton of plugin (PT-185950946) Sep 6, 2023
Copy link
Contributor

@eireland eireland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change in import statements order that you may have fixed in your other PR.
Otherwise, LGTM!

src/components/app.tsx Outdated Show resolved Hide resolved
@lublagg lublagg merged commit 05e8e19 into main Sep 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants