Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Information pop-up is viewable with any window size. (PT-186025103) #12

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Information pop-up is viewable with any window size. (PT-186025103) #12

merged 1 commit into from
Oct 5, 2023
+3 −6

Conversation

lublagg
Copy link
Collaborator

@lublagg lublagg commented Oct 4, 2023

This PR makes the info pop-up automatically resize when the plugin resizes and makes it scrollable as well.

dougmartin
dougmartin approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@dougmartin dougmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be based on the 185951117-bug-fixes branch but you've based the PR off main. Looks good though 👍

@lublagg lublagg changed the base branch from main to 185951219-bug-fixes October 5, 2023 18:40
@lublagg lublagg changed the base branch from 185951219-bug-fixes to main October 5, 2023 18:56
@lublagg lublagg merged commit 7cced4a into main Oct 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougmartin dougmartin dougmartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lublagg @dougmartin