Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement place dropdown options (PT-185951019) #2

Merged
merged 24 commits into from
Sep 25, 2023
Merged

Implement place dropdown options (PT-185951019) #2

merged 24 commits into from
Sep 25, 2023

Conversation

lublagg
Copy link
Collaborator

@lublagg lublagg commented Sep 12, 2023

No description provided.

eireland
eireland approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@eireland eireland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some minor comments, otherwise looks good!

src/components/dropdown.tsx Show resolved Hide resolved
src/components/summary.tsx Outdated Show resolved Hide resolved
src/scripts/api.ts Outdated Show resolved Hide resolved
src/scripts/api.ts Show resolved Hide resolved
src/scripts/api.ts Outdated Show resolved Hide resolved
src/scripts/api.ts Outdated Show resolved Hide resolved
@lublagg lublagg merged commit 3b4590c into 185950946-plugin-layout Sep 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eireland eireland eireland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lublagg @eireland