Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#186621606] Fix Fetch error for Wages and Time Worked queries #27

Closed
wants to merge 2 commits into from

Conversation

eireland
Copy link
Contributor

@eireland eireland commented Feb 9, 2024

Changes query header geographic areas to State, and County for Wages and Time Worked.

@eireland eireland requested a review from lublagg February 9, 2024 17:13
Copy link
Collaborator

@lublagg lublagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this isn't the right approach. Not all of the states have Wages / Time Worked data, and there are no Counties options for these categories. I think that's why Kate originally defined these options using the Region: Multi-Region option.

I believe I've fixed this issue in this PR: #29, because now if we use Regions and there are no matching states we will just get back an empty cell. So I think we can actually close out this PR without merging it in. Sorry for the duplicate work!

@eireland eireland closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants