Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dest file for release.yml [PT-188014351] #32

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

dougmartin
Copy link
Member

This changes the dest file for the release from index-demo.html to index.html.

This changes the dest file for the release from index-demo.html to index.html.
@dougmartin dougmartin requested a review from lublagg August 7, 2024 13:52
@dougmartin
Copy link
Member Author

@lublagg - I've already run this release config so that we have a stable/default plugin url at:

https://nass-plugin.concord.org/

This is needed as the plugin is being added to the "Portals" tab at https://concord-consortium.github.io/codap-data-interactives/build/ and it needs a stable url.

I used the v0.1.0 version in the versions folder which, by date, looks newer than the main branch but there no actual version tags or releases in this repo. Do you want me to create a v0.1.0 tag and release?

@dougmartin
Copy link
Member Author

@lublagg Could you review this so I can merge it? Thanks!

Copy link
Collaborator

@lublagg lublagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@dougmartin dougmartin merged commit 6ef7381 into main Aug 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants