186719430 station selection list #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e default station Styles the selection list.
lublagg
requested changes
Jan 25, 2024
src/utils/getWeatherStations.ts
Outdated
| const fromSecs = fromDate.getTime() / 1000; | ||
| const toSecs = toDate.getTime() / 1000; | ||
| const nearestStations: IStation[] = []; | ||
| console.log(adjustedStationDataset); |
dougmartin
approved these changes
Jan 26, 2024
src/components/App.tsx
Outdated
| @@ -33,8 +33,8 @@ export const App = () => { | |||
|
|
|||
| useEffect(() => { | |||
| initializePlugin({pluginName: kPluginName, version: kVersion, dimensions: kInitialDimensions}); | |||
| adjustStationDataset(weatherStations); //change max data to "present" | |||
| createStationsDataset(weatherStations); //send weather station data to CODAP | |||
| adjustStationDataset(weatherStations as IWeatherStation[]); //change max data to "present" | |||
There was a problem hiding this comment.
Its fine for this PR but it would be good in a future PR to convert the imported json file to a .ts file and type the data in the file so that if the types change but the imported data does not it is caught at compile time.
Fixes the merge conflict with select station list and time zone code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user clicks on the selected station, a drop down of the 5 nearest stations to current location should be shown. User can then change the selected station.