Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

186752905 filter function fixes #27

Merged
merged 7 commits into from
Jan 26, 2024
Merged

186752905 filter function fixes #27

merged 7 commits into from
Jan 26, 2024

Conversation

eireland
Copy link
Contributor

Fixes bugs found by QA:

  • Changing attribute selected to filter does not update the info in the filter modal
  • Expand click handler to include the Edit Icon
  • Made operator list a little wider to accomodate the scroll bar
  • Fixed the "greater than or equal to" text
  • Added unit to the lower value for the between operator
  • Fix bug where input value does not show when above mean or below mean were previously selected
  • Fixed bug where if user changes unit type selection, the filter modal didn't update to the new unit type
  • Changed the default height of the plugin to accomodate the lowest filter modal position by default.
  • Made operator selection list scrollable if the bottom of the list is below the window height.

@eireland
Fixes filter operator dropdrown height in Firefox
39eb041 
Fixes missing units in between lower value in filter table

Fixes click handler for operator edit icon in filter modal

Fixes greater than text
@eireland
Fixes units in filter modal when user changes Units type
de08fbe
@eireland
Changes plugin default height to make it tall enough to fit lowest fi…
0042b2e 
…lter modal by defaulte

Moves filter modal up if window is too short

Makes operator selection list a scrollable list if window is too short.
@eireland
Fixes FilterModal not rerendering when selected attributeToFilter is …
5010573 
…changed
lublagg
lublagg requested changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@lublagg lublagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good 👍 just a console.log to remove

src/components/attribute-filter.tsx Outdated Show resolved Hide resolved
dougmartin
dougmartin approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@dougmartin dougmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@eireland eireland merged commit cd7661f into main Jan 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lublagg lublagg lublagg requested changes

@dougmartin dougmartin dougmartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eireland @dougmartin @lublagg