Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the double input value when switching from between operator to … #35

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

eireland
Copy link
Contributor

…any single value operator

We were using the currentFilterValue stored in state for the variable. When user enters values for the between operator, we store those values into an array. When user switches to a single value operator like equals, it shows the currentFilterValue array as the value in the input field.
This checks to see if currentFilterValue is an array, and if it is, we will just use the first or lower input value of the array.

Copy link
Member

@dougmartin dougmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@eireland eireland merged commit c431602 into main Jan 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants