Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get data bug fixes (PT-186719429) #42

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Get data bug fixes (PT-186719429) #42

merged 5 commits into from
Jan 31, 2024

Conversation

lublagg
Copy link
Contributor

@lublagg lublagg commented Jan 30, 2024

This PR makes the following changes:

  • Disables the Get Data button should be disabled until the date range, location and attributes are selected.
  • Adds hover state for the Get Data button
  • Separates Precipitation in last hour and Precipitation columns
  • Adds icons for status updates
  • Updates "Retrieved" status message color
  • Fixes alignment issues with the Get Data and Clear All buttons

@lublagg lublagg requested a review from eireland January 30, 2024 22:30
eireland
eireland approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@eireland eireland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@eireland eireland merged commit 0bbe11f into main Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eireland eireland eireland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lublagg @eireland