Fix display of report item links in Compare View. #407
Conversation
Codecov ReportBase: 94.28% // Head: 94.28% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #407 +/- ##
=======================================
Coverage 94.28% 94.28%
=======================================
Files 163 163
Lines 5813 5813
Branches 1175 1175
=======================================
Hits 5481 5481
Misses 307 307
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
lublagg
changed the title
There was a problem hiding this comment.
Looks good to me 👍
I think you should wait for @scytacki to also review since we paired to do this work.
There was a problem hiding this comment.
I think this will suffer all of the same problems as the original PR.
https://github.com/concord-consortium/portal-report/pull/404/files
It just makes it more explicit that that this flag is for the compare view. But I think there are several interactives that should be showing their report items in the compare view.
| @@ -213,7 +214,7 @@ export class IframeAnswer extends PureComponent<IProps, IState> { | |||
| {maybeAnswerTextOrLinks} | |||
| </div> | |||
| )} | |||
| {reportItemAnswerItems.map((item, index) => ( | |||
| {!compareView && reportItemAnswerItems.map((item, index) => ( | |||
There was a problem hiding this comment.
Have you checked what happens with open response questions in this case?
As I wrote in the other PR. I think this will prevent open response questions from showing all of there features. It will also prevent something like SageModeler from showing its metrics in the compare view.
|
@lublagg and @dougmartin I think the best incremental work to be done on this is to document the cases. Perhaps I'm wrong, but if I'm right then have this documentation will make it easier for devs and owners to understand how this isn't a simple problem. So making screenshots of what happens with and without this PR for Open Response, Multiple Choice, Sage Modeler, and the bar graph. |
No description provided.