Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make Activity-level the default for Feedback Report [PT-187132915] #429

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

dougmartin
Copy link
Member

Changes the default from question to activity level in the feedback report.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.08%. Comparing base (680ceb2) to head (84a8a96).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
- Coverage   94.08%   94.08%   -0.01%     
==========================================
  Files         167      167              
  Lines        5919     5918       -1     
  Branches     1227     1226       -1     
==========================================
- Hits         5569     5568       -1     
  Misses        325      325              
  Partials       25       25              
Flag Coverage Δ
cypress 92.30% <100.00%> (-0.01%) ⬇️
jest 62.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Feb 29, 2024

Passing run #1751 ↗︎

0 173 5 0 Flakiness 0

Details:

feat: Make Activity-level the default for Feedback Report [PT-187132915]
Project: portal-report Commit: 84a8a96806
Status: Passed Duration: 03:14 💡
Started: Feb 29, 2024 9:27 PM Ended: Feb 29, 2024 9:30 PM

Review all test suite changes for PR #429 ↗︎

Changes the default from question to activity level in the feedback report.

NOTE: this also removes a bug in the response details where the question navigator depended on the feedback level.
@dougmartin dougmartin force-pushed the 187132915-make-activity-feedback-default branch from 780c8d2 to 84a8a96 Compare February 29, 2024 21:22
Copy link
Contributor

@lublagg lublagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@dougmartin dougmartin merged commit 3e21c50 into master Feb 29, 2024
9 checks passed
@dougmartin dougmartin deleted the 187132915-make-activity-feedback-default branch February 29, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants