Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Logging of empty and duplicate score values [PT-187192076] #454

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

dougmartin
Copy link
Member

This fixes two issues:

  1. Empty score values were not being logged. A new logEmptyLabel option was added to support this.
  2. The score value was always being logged when blurred instead of only logging when the score changed on blur.

This fixes two issues:

1. Empty score values were not being logged.  A new logEmptyLabel option was added to support this.
2. The score value was always being logged when blurred instead of only logging when the score changed on blur.
@dougmartin dougmartin requested a review from lublagg March 11, 2024 13:49
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 92.02%. Comparing base (19f7d97) to head (6a974d0).

Files Patch % Lines
...tal-dashboard/feedback/activity-feedback-score.tsx 38.46% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
+ Coverage   91.97%   92.02%   +0.04%     
==========================================
  Files         174      174              
  Lines        6282     6280       -2     
  Branches     1312     1311       -1     
==========================================
+ Hits         5778     5779       +1     
+ Misses        478      476       -2     
+ Partials       26       25       -1     
Flag Coverage Δ
cypress 90.32% <35.71%> (+0.04%) ⬆️
jest 62.77% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Mar 11, 2024

Passing run #1812 ↗︎

0 173 5 0 Flakiness 0

Details:

fix: Logging of empty and duplicate score values [PT-187192076]
Project: portal-report Commit: 6a974d05a6
Status: Passed Duration: 03:23 💡
Started: Mar 11, 2024 1:53 PM Ended: Mar 11, 2024 1:57 PM

Review all test suite changes for PR #454 ↗︎

Copy link
Contributor

@lublagg lublagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@dougmartin dougmartin merged commit 003ac09 into master Mar 11, 2024
8 of 9 checks passed
@dougmartin dougmartin deleted the 187192076-fix-no-score-logging branch March 11, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants