fix: Pull manual scores from feedbacks and not higher level scores attribute [PT-187021319] #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tribute [PT-187021319] The feedbacks.scores attribute is not updated in the selector when the question changes so the scores need to be pulled from the individual student feedback which does change when the question is changed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #460 +/- ##
==========================================
- Coverage 92.05% 91.97% -0.09%
==========================================
Files 174 174
Lines 6357 6364 +7
Branches 1348 1349 +1
==========================================
+ Hits 5852 5853 +1
- Misses 480 486 +6
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Passing run #1828 ↗︎
Details:
Review all test suite changes for PR #460 ↗︎ |
|||||||||||||||
dougmartin
deleted the
187021319-fix-average-score-when-switching-questions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feedbacks.scores attribute is not updated in the selector when the question changes so the scores need to be pulled from the individual student feedback which does change when the question is changed.