Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add secondary researcher header element [PT-187325112] #464

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

dougmartin
Copy link
Member

This adds a secondary header element if the user is a researcher. This new element displays under the main header and shows that the interface is in researcher mode and displays the class name and teacher names.

The teachers of the class were previously not storied in the state so most of the work of this commit is adding that to the state and drilling it down as a prop.

This adds a secondary header element if the user is a researcher.  This new element displays under the main header and shows that the interface is in researcher mode and displays the class name and teacher names.

The teachers of the class were previously not storied in the state so most of the work of this commit is adding that to the state and drilling it down as a prop.
@dougmartin dougmartin requested a review from pjanik March 28, 2024 13:12
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.89%. Comparing base (2347d01) to head (3422506).

Files Patch % Lines
js/components/portal-dashboard/header.tsx 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
- Coverage   91.91%   91.89%   -0.02%     
==========================================
  Files         174      174              
  Lines        6379     6392      +13     
  Branches     1358     1363       +5     
==========================================
+ Hits         5863     5874      +11     
- Misses        491      493       +2     
  Partials       25       25              
Flag Coverage Δ
cypress 90.21% <86.20%> (-0.02%) ⬇️
jest 62.69% <57.89%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Mar 28, 2024

Passing run #1837 ↗︎

0 173 5 0 Flakiness 0

Details:

feat: Add secondary researcher header element [PT-187325112]
Project: portal-report Commit: 3422506adc
Status: Passed Duration: 03:20 💡
Started: Mar 28, 2024 1:17 PM Ended: Mar 28, 2024 1:20 PM

Review all test suite changes for PR #464 ↗︎

Copy link
Member

@pjanik pjanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@dougmartin dougmartin merged commit d16f017 into master Mar 28, 2024
8 of 9 checks passed
@dougmartin dougmartin deleted the 187325112-add-researcher-header-element branch March 28, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants