fix: Student feedback not showing rubric score [PT-188024567] #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rubric score was not being shown when the teacher in the dashboard used the default score setting, which was to score using the rubric when the rubric was present. This commit re-scores the rubric before it is shown to the student if there is no score type set or the score type is rubric and no score is set. Further work needs to be done in the future to update the teacher dashboard to set the score by default.
portal-report
|
||||||||||||||||||||||||||||
| Project |
portal-report
|
| Branch Review |
188024567-show-student-report-score
|
| Run status |
|
| Run duration | 03m 53s |
| Commit |
|
| Committer | Doug Martin |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
187
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rubric score was not being shown when the teacher in the dashboard used the default score setting, which was to score using the rubric when the rubric was present.
This commit re-scores the rubric before it is shown to the student if there is no score type set or the score type is rubric and no score is set.
Further work needs to be done in the future to update the teacher dashboard to set the score by default.