fix: Report item answers not rendering in activity level feedback report [PT-188671164] #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort [PT-188671164] The report item answers iframe was not loaded when the user navigated directly to the activity level feedback panel. This caused the "Show Student Answers" dropdown to show a blank answer for any questions that had report items. With this change all questions in the feedback panel that have report items pre-load all their report item iframes as hidden iframes before any of the student feedback rows are shown. In addition a loading indicator was added while the report item answer is being loaded so that the answer does not look blank while the answer is loading.
portal-report
|
||||||||||||||||||||||||||||
| Project |
portal-report
|
| Branch Review |
188671164-fix-feedback-view-student-answers
|
| Run status |
|
| Run duration | 04m 02s |
| Commit |
|
| Committer | Doug Martin |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
187
|
| View all changes introduced in this branch ↗︎ | |
scytacki
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The report item answers iframe was not loaded when the user navigated directly to the activity level feedback panel. This caused the "Show Student Answers" dropdown to show a blank answer for any questions that had report items.
With this change all questions in the feedback panel that have report items pre-load all their report item iframes as hidden iframes before any of the student feedback rows are shown. In addition a loading indicator was added while the report item answer is being loaded so that the answer does not look blank while the answer is loading.