Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fixed GH Action build issues #199

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

dougmartin
Copy link
Member

@dougmartin dougmartin commented Oct 16, 2023

  • Bumped three action versions due to node 12 deprecation
    • actions/checkout@v2 to actions/checkout@v3
    • actions/setup-node@v2 to actions/setup-node@v3
    • actions/checkout@v2 to actions/checkout@v3
  • Converted s3-deploy to use concord-consortium/s3-deploy-action@v1

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1e2eb08) 84.61% compared to head (d4484f1) 84.61%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   84.61%   84.61%           
=======================================
  Files           2        2           
  Lines          39       39           
  Branches       13       13           
=======================================
  Hits           33       33           
  Misses          6        6           
Flag Coverage Δ
jest 84.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Bumped three action versions due to node 12 deprecation
  - actions/checkout@v2 to actions/checkout@v3
  - actions/setup-node@v2 to actions/setup-node@v3
  - actions/checkout@v2 to actions/checkout@v3
- Converted s3-deploy to use concord-consortium/s3-deploy-action@v1
@dougmartin dougmartin force-pushed the fix-node-12-deprecation-on-gh-actions branch from 7c07e9b to d4484f1 Compare October 17, 2023 11:53
@dougmartin dougmartin changed the title build: Bumped three action versions due to node 12 deprecation build: Fixed GH Action build issues Oct 17, 2023
@dougmartin
Copy link
Member Author

dougmartin commented Oct 17, 2023

Now working S3 deploy (of this branch): https://researcher-reports.concord.org/branch/fix-node-12-deprecation-on-gh-actions/

Copy link
Member

@scytacki scytacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I don't see any files/assets being copied in webpack.config.js so you didn't have to do any extra work to support the DEPLOY_PATH. Nice. :)

@dougmartin dougmartin merged commit 43024c1 into master Oct 17, 2023
5 checks passed
@dougmartin dougmartin deleted the fix-node-12-deprecation-on-gh-actions branch October 17, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants