Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Split glossary data column in to three columns [PT-187885620] #260

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

dougmartin
Copy link
Member

The new columns are:

  • res_N_glossary_text_definitions
  • res_N_glossary_audio_definitions
  • res_N_glossary_audio_link

This also adds a module to generate portal report urls.

@dougmartin dougmartin requested a review from pjanik July 15, 2024 15:24
Copy link
Member

@pjanik pjanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dougmartin dougmartin force-pushed the 187885620-split-glossary-data-into-two-columns branch from 19bd9cb to 803abd8 Compare July 17, 2024 14:07
The new columns are:

- res_N_glossary_text_definitions
- res_N_glossary_audio_definitions
- res_N_glossary_audio_link

This also adds a module to generate portal report urls and offering_id to the details report.
@dougmartin dougmartin force-pushed the 187885620-split-glossary-data-into-two-columns branch from 803abd8 to 1ed5c1c Compare July 17, 2024 18:49
@dougmartin dougmartin merged commit 93e351b into master Jul 17, 2024
2 checks passed
@dougmartin dougmartin deleted the 187885620-split-glossary-data-into-two-columns branch July 17, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants