feat: Extract phrases and emoticons [PT-188319600] [PT-188319636] #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougmartin
force-pushed
the
188319600-add-phrase-extraction
branch
from
d426a53
to
eb47a62
Compare
This updates the plugin to pass the full trimmed text when pattern matching text and then changes the word boundary metacharacters in the pattern to be optional if the text begins/ends with non-word characters. This also adds a missing escape of any regex characters in the free form text and changes spaces to match multiple spaces and expands quotes to "smart" quotes. Finally this also disables the word highlighting as this doesn't work for phrases or existing word list features.
dougmartin
force-pushed
the
188319600-add-phrase-extraction
branch
from
eb47a62
to
a5eea05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the plugin to pass the full trimmed text when pattern matching text and then changes the word boundary metacharacters in the pattern to be optional if the text begins/ends with non-word characters.
This also adds a missing escape of any regex characters in the free form text and changes spaces to match multiple spaces.