Load Web Worker script from a correct location #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scytacki
reviewed
Feb 13, 2024
Comment on lines
+179
to
+183
| })] : []), | ||
| // Define DEPLOY_PATH globally so it can be used to load Web Worker script from a correct location | ||
| new webpack.DefinePlugin({ | ||
| '__WEBPACK_DEPLOY_PATH__': JSON.stringify(DEPLOY_PATH || ".") | ||
| }) |
There was a problem hiding this comment.
@pjanik rather than doing this, perhaps you can use the built in webpack variable __webpack_public_path__? This is described here: https://github.com/concord-consortium/starter-projects/blob/master/doc/deploy.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/187028887
https://www.pivotaltracker.com/story/show/186957289
Another PR has been created to improve the new release process. The Web Worker script was being loaded from a local directory instead of the /version/v2.7.0 directory after the production release and that was causing the issue reported by Trudi.
I've explored better approaches, and there are two separate ones:
So, I have opted to pass the deployment path to the TS script and use it there.