Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Authored state lookup in authoring mode [PT-187809702] #145

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

dougmartin
Copy link
Member

This fixes a couple of issues found when testing out authoring:

In authoring mode the authoredState comes in as a string which was causing the authoring preview to show an error that the experiment was not selected.

There was still a reference to the "Save Authored State" button, which I believe came from the S3 authoring version.

This fixes a couple of issues found when testing out authoring:

In authoring mode the authoredState comes in as a string which was causing the authoring preview to show an error that the experiment was not selected.

There was still a reference to the "Save Authored State" button, which I believe came from the S3 authoring version.
@dougmartin dougmartin requested a review from pjanik June 20, 2024 13:40
Copy link
Member

@pjanik pjanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dougmartin dougmartin merged commit 5440236 into master Jun 20, 2024
5 checks passed
@dougmartin dougmartin deleted the 187809702-fix-authored-state-lookup branch June 20, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants