Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Stop series data not saving when max values reached [PT-187949831] #167

Merged
merged 1 commit into from
Jul 18, 2024
Merged

fix: Stop series data not saving when max values reached [PT-187949831] #167

merged 1 commit into from
Jul 18, 2024

Commits on Jul 18, 2024

  1. fix: Stop series data not saving when max values reached [PT-187949831] 

    Previously there was a useCallback() wrapper on the stop time series function that depended on the formData but this caused issues with the formData being captured as an empty array at the start of multiple runs where the runs hit their max number of values.

This fix adds a ref to the formData so that the closure is not created.
    @dougmartin
    dougmartin committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    b6d336e View commit details
    Browse the repository at this point in the history