feat: Finished csv import scripts [PT-188117054] #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougmartin
force-pushed
the
188067139-finish-data-import-scripts
branch
from
e2963b7
to
d25d1e2
Compare
pjanik
requested changes
Sep 6, 2024
There was a problem hiding this comment.
It looks great. 👍
The only thing we need to change is the CopyPlugin. I don't think we can use it these days, as it doesn't work with the new release script and generally it's not the best approach compared to assets loader (caching, etc.).
We should replace it with an assets loader that will generate a URL. I'm pretty sure the default limit for inlining is smaller than the size of this file, but we can also explicitly set this path to use the asset/resource type.
We can also merge this PR, and I can do it myself later - whichever you prefer.
The copy-webpack-plugin was added in the initial commit to copy the values.json from the public folder. Instead the values.json file is imported into the code but webpack is configured to return the filename instead of the data for the file so that we can call fetch with the filename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.