Add tests for pluginRegistry #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR @bunysae. I did not open my editor this weekend so I haven't had time yet to look into this, sorry. |
|
So I don't remember much about how this code works, but I just did update the tooling and dependencies. Could you try rebasing? Apologies for any conflicts. |
|
@bunysae I don't think that did the trick. All the changes are now showing up in the diff, and according to GitHub there's still merge conflicts. |
|
@novemberborn |
|
@bunysae cool, thanks. Looks like there are some linter errors now. You can run |
|
Thank you @bunysae. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added tests for
pluginRegistryin order to fix #1.