Requesting new outputs for OpenVDB #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetov
changed the title
beckermr
reviewed
Jan 14, 2025
requests/add-openvdb-outputs.yml
Outdated
Comment on lines
3
to
4
| - openvdb: openvdb* | ||
| - openvdb: nanovdb* |
There was a problem hiding this comment.
Suggested change
| - openvdb: openvdb* | |
| - openvdb: nanovdb* | |
| - openvdb: openvdb-* | |
| - openvdb: nanovdb-* |
There was a problem hiding this comment.
Thank you for reviewing!
I updated like you suggest, but added nanovdb without glob as well.
I have used underscore in the output names in the recipe. Would dashes be preferable?
action: add_feedstock_output
feedstock_to_output_mapping:
- openvdb: openvdb-*
- openvdb: nanovdb
- openvdb: nanovdb-*There was a problem hiding this comment.
Either a dash or underscore is fine. I find dashes aesthetically more please but this is a personal preference.
There was a problem hiding this comment.
I took a quick look at the referenced example packages with multiple outputs and they all used -, so I'll follow that.
Please merge if you are happy with the req and I'll push with dashes in my PR :).
beckermr
requested changes
Jan 14, 2025
beckermr
approved these changes
Jan 14, 2025
tetov
added a commit
to conda-forge/openvdb-feedstock
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Description
I'm adding NanoVDB from the OpenVDB project well as packaging tools for OpenVDB and NanoVDB.