Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow multiple outputs in ncrystal-feedstock #1344

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Conversation

tkittel
Copy link
Member

@tkittel tkittel commented Jan 25, 2025

In order to split the C++/library parts of NCrystal from the Python layer, the ncrystal-feedstock needs to be modified to use multiple outputs. So before there was just an "ncrystal" package, but in the future there will be at least "ncrystal-core", "ncrystal-python", and "ncrystal" packages, where the last will be a metapackage depending on the rest and ensuring synchronisation of versions. In the future the ncrystal-core itself might be split further (into libs, headers, data files), but that is not going to happen in the short term.

I am the maintainer of the ncrystal-feedstock, so I count myself as having been pinged :-)

  • I want to add a package output to a feedstock:
    • Pinged the relevant feedstock team(s)
    • Added a small description of why the output is being added.

@tkittel tkittel requested a review from a team as a code owner January 25, 2025 11:11
@beckermr beckermr merged commit 41358fa into conda-forge:main Jan 25, 2025
1 check passed
@h-vetinari
Copy link
Member

Why not call the C++ library libncrystal?

@tkittel
Copy link
Member Author

tkittel commented Jan 25, 2025

@h-vetinari mostly because it is not 100% just the lib, but more importantly to follow 1-to-1 the naming of the corresponding pypi packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants