Fix error handling #1347
Closed
Fix error handling #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofang
force-pushed
the
fix_error_handling
branch
from
cd567c0 to
08b575f
Compare
leofang
force-pushed
the
fix_error_handling
branch
from
08b575f to
d7bd500
Compare
|
urgh, github closed my PR while I was fixing a dirty rebase... |
|
PTAL |
|
Seems like a known bug in pygithub: PyGithub/PyGithub#3179 |
beckermr
requested changes
Jan 26, 2025
|
Thanks, Matt. The upstream is working on a fix (PyGithub/PyGithub#3180) so I was hoping to quickly work around this and revert it once a new release is out. But if you have time to refine it I am also happy 🙏 |
|
Are you thinking of checking |
|
yes see #1348 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try this to see if #1346 can be fixed. I can reproduce the error locally and I noticed that despite it's a 404 error, pygithub does not raise
github.UnknownObjectExceptionas documented, but instead raises the basegithub.GithubtException. Something might have changed in recent pygithub versions. I tested this with 2.4.0.Let's try to merge this and see if it fixes 1346.