-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to version 1.0.1 #32
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.11.08.21.35.56
There's a couple of issues, but one seems to be the |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Ah, the error message relating to Can you configure the Conda recipe so that it builds against the limited C API? |
I had to fix this in PyERFA: liberfa/pyerfa#120 - we should do something similar for astropy-healpix. Basically PyPy doesn't support the limited API so it makes sense to make that typedef conditional on whether PyPy is being used. This should be fixed in astropy-healpix and I would suggest enabling the PyPy 3.9 wheels there as I did for PyERFA as this will help guard against other issues in future. It's also possible to add a patch here for now if we don't want to have to release a new astropy-healpix version. |
I've added patches to fix the build issues - not sure if it's best to do a release of 1.0.0 with these patches, then remove them in a later version, or skip 1.0.0 in conda, fix upstream, and do a release without any patches? |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.11.18.16.21.52
Whatever you prefer. I was planning to do a release very soon anyway. |
If you don't mind doing a release with patches would be nice to do a release - the reason I got on to this was it's blocking sunpy from doing the Python 3.12 migration 😄 (via reproject doing a Python 3.12 migration) |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.11.27.19.54.17
Fab, I updated to version 1.0.1 and removed the patches, and all seems to have worked 🎉 I think this is good to merge now |
Looks like this is redundant now 1.0.2 has been released |
An attempt to see what's going wrong with the CI, since the logs aren't available in all the older PRs.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)