Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to version 1.0.1 #32

Closed
wants to merge 10 commits into from
Closed

Update to version 1.0.1 #32

wants to merge 10 commits into from

Conversation

dstansby
Copy link

@dstansby dstansby commented Nov 8, 2023

An attempt to see what's going wrong with the CI, since the logs aren't available in all the older PRs.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • Old-style Python selectors (py27, py34, py35, py36) are deprecated. Instead, consider using the int py. For example: # [py>=36]. See lines [15]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Old-style Python selectors (py27, py35, etc) are only available for Python 2.7, 3.4, 3.5, and 3.6. Please use explicit comparisons with the integer py, e.g. # [py==37] or # [py>=37]. See lines [15]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@dstansby
Copy link
Author

dstansby commented Nov 8, 2023

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits November 8, 2023 22:06
@dstansby
Copy link
Author

dstansby commented Nov 8, 2023

There's a couple of issues, but one seems to be the pypy builds taking issue with these lines:

https://github.com/astropy/astropy-healpix/blob/d116ecc3efb84bda71f5866b120abdc96a815446/astropy_healpix/_core.c#L17-L19

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@lpsinger
Copy link

lpsinger commented Nov 9, 2023

An attempt to see what's going wrong with the CI, since the logs aren't available in all the older PRs.

Ah, the error message relating to _typeobject is because the source code is expecting that you are building it against Python's Limited C API. We do that for wheels:

https://github.com/astropy/astropy-healpix/blob/3d88e85fc61891ba61f42b470f028efc770ae6cd/setup.cfg#L83

Can you configure the Conda recipe so that it builds against the limited C API?

@astrofrog
Copy link
Contributor

astrofrog commented Nov 9, 2023

I had to fix this in PyERFA: liberfa/pyerfa#120 - we should do something similar for astropy-healpix. Basically PyPy doesn't support the limited API so it makes sense to make that typedef conditional on whether PyPy is being used.

This should be fixed in astropy-healpix and I would suggest enabling the PyPy 3.9 wheels there as I did for PyERFA as this will help guard against other issues in future. It's also possible to add a patch here for now if we don't want to have to release a new astropy-healpix version.

@dstansby
Copy link
Author

I've added patches to fix the build issues - not sure if it's best to do a release of 1.0.0 with these patches, then remove them in a later version, or skip 1.0.0 in conda, fix upstream, and do a release without any patches?

@dstansby
Copy link
Author

@conda-forge-admin, please rerender

@lpsinger
Copy link

Whatever you prefer. I was planning to do a release very soon anyway.

@dstansby
Copy link
Author

If you don't mind doing a release with patches would be nice to do a release - the reason I got on to this was it's blocking sunpy from doing the Python 3.12 migration 😄 (via reproject doing a Python 3.12 migration)

@lpsinger
Copy link

If you don't mind doing a release with patches would be nice to do a release - the reason I got on to this was it's blocking sunpy from doing the Python 3.12 migration 😄 (via reproject doing a Python 3.12 migration)

See astropy/astropy-healpix#200.

@dstansby dstansby changed the title Update to version 1.0.0 Update to version 1.0.1 Nov 28, 2023
@dstansby
Copy link
Author

@conda-forge-admin, please rerender

@dstansby
Copy link
Author

Fab, I updated to version 1.0.1 and removed the patches, and all seems to have worked 🎉 I think this is good to merge now

@dstansby
Copy link
Author

Looks like this is redundant now 1.0.2 has been released

@dstansby dstansby closed this Jan 11, 2024
@dstansby dstansby deleted the 1.0.0 branch January 11, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants