-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo-c v0.9.31 #10
cargo-c v0.9.31 #10
Conversation
…nda-forge-pinning 2024.03.22.08.38.34
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Linking to git is a new one for me. I didn't even know git offered an API. |
This flag comes from CFLAGS set by our channel? |
I've seen many flags confuse host and build in rust projects, and not consider PPC64LE at all. It might be a bug upstream in a recent change? |
Seems like (some?) of the failures aren't specific to this new version of cargo-c |
The wrong compiler is being used for the linux cross-compile.
The logs show that |
I can replicate this error locally:
|
Need to investigate why |
Possibly, this package now depends on https://github.com/conda-forge/libgit2-feedstock |
…nda-forge-pinning 2024.03.28.19.00.41
…nda-forge-pinning 2024.03.28.19.00.41
The remaining issue with PowerPC is because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the build passes, I'm good with this. However, it does increase the minimum GLIBC version that is required.
@conda-forge-admin please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@@ -22,6 +23,7 @@ requirements: | |||
- zlib # [not win] | |||
host: | |||
- libcurl # [not win] | |||
- libgit2 >=1.7.2,<1.8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this here? is it not compatible with 1.8.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/rust-lang/git2-rs/pull/1032/files
it seems it just isn't compatible yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Truthfully, for me this is the larger issue given that libgit2 has already moved to 1.8 conda-forge wide and this might cause some conflicts.
@conda-forge-admin please rerender |
…nda-forge-pinning 2024.05.05.00.21.09
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: false
to yourconda-forge.yml
. If you encounter issues with this feature please ping the bot teamconda-forge/bot
.Analysis by source code inspection shows no discrepancy with the stated requirements in the meta.yaml.
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8388296342, please use this URL for debugging.