Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert pinning libxml2 looser #329

Closed
wants to merge 1 commit into from

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Oct 10, 2022

@xhochy xhochy requested a review from a team as a code owner October 10, 2022 12:33
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xhochy xhochy mentioned this pull request Oct 10, 2022
5 tasks
@hmaarrfk
Copy link
Contributor

if you are sure you don't need to add "pin_stricter" then go for it!

@xhochy
Copy link
Member Author

xhochy commented Oct 10, 2022

I would leave this around at least until tomorrow morning or until @isuruf also gets a chance to review it.

@hmaarrfk
Copy link
Contributor

I think a related question: conda-forge/conda-forge-pinning-feedstock#3368

@xhochy could you also link us to any feedstocks that show the issue?

@xhochy
Copy link
Member Author

xhochy commented Oct 10, 2022

https://github.com/conda-forge/libxmlsec1-feedstock encounters an issue. You don't see that on the feedstock as the newly build packages have a libxml2~2.9 pin. The repodata patch only get actives once repodata has been rebuilt. Thus tests stay green there.

@hmaarrfk
Copy link
Contributor

$ mamba create --name xml libxmlsec1 python --channel conda-forge --override-channels

                  __    __    __    __
                 /  \  /  \  /  \  /  \
                /    \/    \/    \/    \
███████████████/  /██/  /██/  /██/  /████████████████████████
              /  / \   / \   / \   / \  \____
             /  /   \_/   \_/   \_/   \    o \__,
            / _/                       \_____/  `
            |/
        ███╗   ███╗ █████╗ ███╗   ███╗██████╗  █████╗
        ████╗ ████║██╔══██╗████╗ ████║██╔══██╗██╔══██╗
        ██╔████╔██║███████║██╔████╔██║██████╔╝███████║
        ██║╚██╔╝██║██╔══██║██║╚██╔╝██║██╔══██╗██╔══██║
        ██║ ╚═╝ ██║██║  ██║██║ ╚═╝ ██║██████╔╝██║  ██║
        ╚═╝     ╚═╝╚═╝  ╚═╝╚═╝     ╚═╝╚═════╝ ╚═╝  ╚═╝

        mamba (0.27.0) supported by @QuantStack

        GitHub:  https://github.com/mamba-org/mamba
        Twitter: https://twitter.com/QuantStack

█████████████████████████████████████████████████████████████


Looking for: ['libxmlsec1', 'python']

conda-forge/linux-64                                        Using cache
conda-forge/noarch                                          Using cache
Transaction

  Prefix: /home/mark/mambaforge/envs/xml

  Updating specs:

   - libxmlsec1
   - python


  Package               Version  Build               Channel                    Size
──────────────────────────────────────────────────────────────────────────────────────
  Install:
──────────────────────────────────────────────────────────────────────────────────────

  + _libgcc_mutex           0.1  conda_forge         conda-forge/linux-64     Cached
  + _openmp_mutex           4.5  2_gnu               conda-forge/linux-64     Cached
  + bzip2                 1.0.8  h7f98852_4          conda-forge/linux-64     Cached
  + ca-certificates   2022.9.24  ha878542_0          conda-forge/linux-64     Cached
  + gettext            0.19.8.1  h27087fc_1009       conda-forge/linux-64     Cached
  + icu                    70.1  h27087fc_0          conda-forge/linux-64     Cached
  + ld_impl_linux-64     2.36.1  hea4e1c9_2          conda-forge/linux-64     Cached
  + libffi                3.4.2  h7f98852_5          conda-forge/linux-64     Cached
  + libgcc-ng            12.1.0  h8d9b700_16         conda-forge/linux-64     Cached
  + libgcrypt            1.10.1  h166bdaf_0          conda-forge/linux-64     Cached
  + libgomp              12.1.0  h8d9b700_16         conda-forge/linux-64     Cached
  + libgpg-error           1.45  hc0c96e0_0          conda-forge/linux-64     Cached
  + libiconv               1.17  h166bdaf_0          conda-forge/linux-64     Cached
  + libnsl                2.0.0  h7f98852_0          conda-forge/linux-64     Cached
  + libsqlite            3.39.4  h753d276_0          conda-forge/linux-64     Cached
  + libstdcxx-ng         12.1.0  ha89aaad_16         conda-forge/linux-64     Cached
  + libtool               2.4.6  h9c3ff4c_1008       conda-forge/linux-64     Cached
  + libuuid              2.32.1  h7f98852_1000       conda-forge/linux-64     Cached
  + libxml2              2.10.2  h4c7fe37_1          conda-forge/linux-64     Cached
  + libxmlsec1           1.2.34  h5614a37_0          conda-forge/linux-64     Cached
  + libxslt              1.1.35  h8affb1d_0          conda-forge/linux-64     Cached
  + libzlib              1.2.12  h166bdaf_4          conda-forge/linux-64     Cached
  + ncurses                 6.3  h27087fc_1          conda-forge/linux-64     Cached
  + openssl              1.1.1q  h166bdaf_0          conda-forge/linux-64     Cached
  + pip                  22.2.2  pyhd8ed1ab_0        conda-forge/noarch       Cached
  + python               3.10.6  h582c2e5_0_cpython  conda-forge/linux-64       30MB
  + readline              8.1.2  h0f457ee_0          conda-forge/linux-64     Cached
  + setuptools           65.4.1  pyhd8ed1ab_0        conda-forge/noarch       Cached
  + tk                   8.6.12  h27826a3_0          conda-forge/linux-64     Cached
  + tzdata                2022d  h191b570_0          conda-forge/noarch       Cached
  + wheel                0.37.1  pyhd8ed1ab_0        conda-forge/noarch       Cached
  + xz                    5.2.6  h166bdaf_0          conda-forge/linux-64     Cached
  + zlib                 1.2.12  h166bdaf_4          conda-forge/linux-64     Cached

  Summary:

  Install: 33 packages

  Total download: 30MB

──────────────────────────────────────────────────────────────────────────────────────

python                                              30.4MB @  42.3MB/s  0.7s
Preparing transaction: done
Verifying transaction: done
Executing transaction: done

To activate this environment, use

     $ mamba activate xml

To deactivate an active environment, use

     $ mamba deactivate

(base) ✔ ~ [fixup_video_tests_for_1060|✔]
09:58 $ mamba activate xml
(xml) ✔ ~ [fixup_video_tests_for_1060|✔]
09:58 $ python -c "from ctypes import CDLL; CDLL('libxmlsec1.so')"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/mark/mambaforge/envs/xml/lib/python3.10/ctypes/__init__.py", line 374, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: /home/mark/mambaforge/envs/xml/lib/python3.10/lib-dynload/../../libxmlsec1.so: undefined symbol: xmlNanoFTPInit, version LIBXML2_2.4.30

@hmaarrfk
Copy link
Contributor

One reason why is that it might have been deprecated in 2.10 which may have triggered some different compilation options:
https://gitlab.gnome.org/GNOME/libxml2/-/commit/9e0ca5a19f86299efee67598ccd4b797dc219002

@hmaarrfk
Copy link
Contributor

And it was disabled by default in https://gitlab.gnome.org/GNOME/libxml2/-/commit/776b00284d8a3fe6f4fb408475c6a22f0767cca2

You can see the tags which have that commit enabled by clicking on the "three dots" at the top.
image

Do you want to recompile libxml2 with the options you need enabled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants