capture build string variations in hdf5 1.14.3 patch #614
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| has_depends: hdf5 >=1.14.2,<1.14.3.0a0 | ||
| timestamp_lt: 1701868616000 | ||
| has_depends: hdf5 >=1.14.2,<1.14.3.0a0?( *) | ||
| timestamp_lt: 1702066879000 |
There was a problem hiding this comment.
Could you please share a bit about the timestamp change? It appears the new timestamp is more recent than the previous one
There was a problem hiding this comment.
I feel like the timestamp should be removed for this patch, we are claiming ABI compatibility, so it should be fine to remove outright.
The problem is that packages may still try to build with the old pin.
There was a problem hiding this comment.
Wonder if we should just rebuild the hdf5 packages to include a better run_exports line
While in theory dropping the timestamp condition would mean anything would be patched. Really it would mean we patch the repodata based on whenever this feedstock last built a package with a new patch. Though when that happens is at some arbitrary time (in contrast to being truly unbounded)
There was a problem hiding this comment.
I think this is really out of scope for now.
We should really just answer this question in my mind:
conda-forge/conda-forge-pinning-feedstock#3368
For now this PR looks like a step in the right direction. the timestamp still exists so itisn't so wide reaching, but there is still a risk of systems being built with 1.14.2 instead of 1.14.3 that would carry the 'x.x.x' limitations
|
Thank you. |
Update rule in #611 to capture dependencies with build string pinning, which would be anything that build against hdf5 with mpi, e.g. petsc.
Checklist
generate_patch_json.pyif absolutely necessary.pre-commit run -aand ensured all files pass the linting checks.python show_diff.pyand posted the output as part of the PR.showdiff output