Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight package validation failure for a new output #2432

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Highlight package validation failure for a new output #2432

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcf86b6
Highlight package validation failure for a new output
isuruf Jan 29, 2025
3c557a5
Update infrastructure.md
isuruf Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions docs/maintainer/infrastructure.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,16 +673,9 @@ works as follows.
4. If all of the validation passes, the package is then copied to the `conda-forge`
channel.

We attempt to report errors in this process to users via comments on commits/issues in the feedstocks.
Sometimes these reports fail. If you think you are having trouble with uploads, make sure to check/try
the following things:
There are two scenarios we consider:

- Ensure that `conda_forge_output_validation: true` is set in your `conda-forge.yml`.
- Retry the package build and upload by pushing an empty commit to the feedstock.
- Rerender the feedstock in a PR from a fork of the feedstock and merge.
- Request a feedstock token reset via our [admin-requests repo](https://github.com/conda-forge/admin-requests?tab=readme-ov-file#reset-your-feedstock-token).
- Request that any new packages be added to the allowed outputs for the feedstock
via our [admin-requests repo](https://github.com/conda-forge/admin-requests?tab=readme-ov-file#add-a-package-output-to-a-feedstock).
### Package validation failed for a new output name

New packages that are added to existing feedstocks are not registered automatically in order to prevent
typo squatting and other malicious activities. Package outputs are added during feedstock creation.
Expand All @@ -695,6 +688,19 @@ In this case, you can use our [admin-requests repo](https://github.com/conda-for
to add a glob pattern that matches the new package name pattern. We use the Python `fnmatch` module syntax.
Output packages that match these patterns will be automatically registered for your feedstock.

### Package validation failed for an existing output name

We attempt to report errors in this process to users via comments on commits/issues in the feedstocks.
Sometimes these reports fail. If you think you are having trouble with uploads, make sure to check/try
the following things:

- Ensure that `conda_forge_output_validation: true` is set in your `conda-forge.yml`.
- Retry the package build and upload by pushing an empty commit to the feedstock.
- Rerender the feedstock in a PR from a fork of the feedstock and merge.
- Request a feedstock token reset via our [admin-requests repo](https://github.com/conda-forge/admin-requests?tab=readme-ov-file#reset-your-feedstock-token).
- Request that any new packages be added to the allowed outputs for the feedstock
via our [admin-requests repo](https://github.com/conda-forge/admin-requests?tab=readme-ov-file#add-a-package-output-to-a-feedstock).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This point is in the wrong section now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already in the previous section. Removed it from here


## Stages of package building and involved infrastructure

Packages in conda-forge are almost[^manual-builds] always built through CI.
Expand Down
Loading